diff --git a/cameleer-server-app/src/main/java/com/cameleer/server/app/controller/DeploymentController.java b/cameleer-server-app/src/main/java/com/cameleer/server/app/controller/DeploymentController.java index 8354b358..2f362003 100644 --- a/cameleer-server-app/src/main/java/com/cameleer/server/app/controller/DeploymentController.java +++ b/cameleer-server-app/src/main/java/com/cameleer/server/app/controller/DeploymentController.java @@ -172,7 +172,8 @@ public class DeploymentController { return ResponseEntity.accepted().body(promoted); } catch (IllegalArgumentException e) { auditService.log("promote_deployment", AuditCategory.DEPLOYMENT, deploymentId.toString(), - Map.of("appSlug", appSlug, "error", e.getMessage()), + Map.of("sourceEnv", env.slug(), "targetEnv", request.targetEnvironment(), + "appSlug", appSlug, "error", e.getMessage()), AuditResult.FAILURE, httpRequest); return ResponseEntity.status(HttpStatus.NOT_FOUND) .body(Map.of("error", e.getMessage())); diff --git a/cameleer-server-app/src/test/java/com/cameleer/server/app/controller/DeploymentControllerAuditIT.java b/cameleer-server-app/src/test/java/com/cameleer/server/app/controller/DeploymentControllerAuditIT.java index 196fdd87..16298486 100644 --- a/cameleer-server-app/src/test/java/com/cameleer/server/app/controller/DeploymentControllerAuditIT.java +++ b/cameleer-server-app/src/test/java/com/cameleer/server/app/controller/DeploymentControllerAuditIT.java @@ -46,10 +46,11 @@ class DeploymentControllerAuditIT extends AbstractPostgresIT { aliceJwt = securityHelper.createToken("user:alice", "user", List.of("OPERATOR")); adminJwt = securityHelper.adminToken(); - // Clean up deployment-related tables + // Clean up deployment-related tables and test-created environments jdbcTemplate.update("DELETE FROM deployments"); jdbcTemplate.update("DELETE FROM app_versions"); jdbcTemplate.update("DELETE FROM apps"); + jdbcTemplate.update("DELETE FROM environments WHERE slug LIKE 'promote-target-%'"); jdbcTemplate.update("DELETE FROM audit_log"); // Ensure alice exists in the users table (required for deployments.created_by FK)