cameleer/cameleer-server
1
0
Fork 0
Code Issues 43 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: improve DO_TRY diagram layout and node text clipping
All checks were successful
CI / cleanup-branch (push) Has been skipped
Details
CI / build (push) Successful in 1m5s
Details
CI / docker (push) Successful in 1m14s
Details
CI / deploy (push) Successful in 49s
Details
CI / deploy-feature (push) Has been skipped
Details

Browse Source 
- Use NETWORK_SIMPLEX placement for vertical centering of root flow nodes
- Skip structural edges from all compound nodes to descendants (not just DO_TRY)
- Reduce DO_TRY section spacing from NODE_SPACING*0.4 to fixed 20px
- Use SVG clipPath for node text instead of character-count truncation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
hsiegeln
2026-03-28 17:28:07 +01:00
parent 6a1d199da6
commit 55e1c7cbb5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cameleer3-server-app/src/main/java/com/cameleer3/server/app/diagram/ElkDiagramRenderer.java
View File

@@ -292,11 +292,11 @@ public class ElkDiagramRenderer implements DiagramRenderer {
root.setProperty(CoreOptions.HIERARCHY_HANDLING, HierarchyHandling.INCLUDE_CHILDREN); root.setProperty(CoreOptions.HIERARCHY_HANDLING, HierarchyHandling.INCLUDE_CHILDREN);
root.setProperty(CoreOptions.EDGE_ROUTING, EdgeRouting.POLYLINE); root.setProperty(CoreOptions.EDGE_ROUTING, EdgeRouting.POLYLINE);
root.setProperty(org.eclipse.elk.alg.layered.options.LayeredOptions.NODE_PLACEMENT_STRATEGY, root.setProperty(org.eclipse.elk.alg.layered.options.LayeredOptions.NODE_PLACEMENT_STRATEGY,
NodePlacementStrategy.LINEAR_SEGMENTS); NodePlacementStrategy.NETWORK_SIMPLEX);
return root; return root;
} }
/** Create ELK edges, skipping DO_TRY-to-descendant and cross-root edges. */ /** Create ELK edges, skipping structural compound-to-child edges and cross-root edges. */
private void createElkEdges(RouteGraph graph, LayoutContext ctx) { private void createElkEdges(RouteGraph graph, LayoutContext ctx) {
if (graph.getEdges() == null) return; if (graph.getEdges() == null) return;
for (RouteEdge re : graph.getEdges()) { for (RouteEdge re : graph.getEdges()) {
@@ -304,8 +304,9 @@ public class ElkDiagramRenderer implements DiagramRenderer {
ElkNode targetElk = ctx.elkNodeMap.get(re.getTarget()); ElkNode targetElk = ctx.elkNodeMap.get(re.getTarget());
if (sourceElk == null || targetElk == null) continue; if (sourceElk == null || targetElk == null) continue;
// Skip edges from DO_TRY to its own children (keep continuation edges) // Skip edges from any compound node to its own descendants
if (ctx.doTryNodeIds.contains(re.getSource()) && isDescendantOf(targetElk, sourceElk)) { // (these are structural edges, not flow edges)
if (ctx.compoundNodeIds.contains(re.getSource()) && isDescendantOf(targetElk, sourceElk)) {
continue; continue;
} }
// Skip edges that cross ELK root boundaries // Skip edges that cross ELK root boundaries
@@ -334,7 +335,7 @@ public class ElkDiagramRenderer implements DiagramRenderer {
if (sections.size() < 2) continue; if (sections.size() < 2) continue;
double startY = sections.stream().mapToDouble(ElkNode::getY).min().orElse(0); double startY = sections.stream().mapToDouble(ElkNode::getY).min().orElse(0);
double spacing = NODE_SPACING * 0.4; double spacing = 20;
double currentY = startY; double currentY = startY;
for (ElkNode section : sections) { for (ElkNode section : sections) {
section.setY(currentY); section.setY(currentY);