fix: hoist DetailPanel into AppShell detail slot for proper slide-in

DetailPanel is a flex sibling that slides in from the right — it must be rendered at the AppShell level via the detail prop, not inside the page content. Add DetailPanelContext so pages can push their panel content up to LayoutShell, which passes it to AppShell.detail. Applied to Dashboard (exchange detail) and AgentHealth (instance detail). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-24 18:28:03 +01:00
parent 0a5f4a03b5
commit 5de792744e
4 changed files with 192 additions and 104 deletions
--- a/ui/src/pages/Dashboard/Dashboard.tsx
+++ b/ui/src/pages/Dashboard/Dashboard.tsx
@@ -1,4 +1,4 @@
-import { useState, useMemo, useCallback } from 'react'
+import { useState, useMemo, useCallback, useEffect } from 'react'
 import { useParams, useNavigate } from 'react-router'
 import {
  DataTable,
@@ -22,6 +22,7 @@ import {
 import { useDiagramLayout } from '../../api/queries/diagrams'
 import type { ExecutionSummary } from '../../api/types'
 import { mapDiagramToRouteNodes } from '../../utils/diagram-mapping'
+import { useDetailPanelSlot } from '../../components/DetailPanelContext'
 import styles from './Dashboard.module.css'

 // Row type extends ExecutionSummary with an `id` field for DataTable
@@ -174,6 +175,7 @@ const SHORTCUTS = [
 export default function Dashboard() {
  const { appId, routeId } = useParams<{ appId: string; routeId: string }>()
  const navigate = useNavigate()
+  const { setDetail } = useDetailPanelSlot()
  const [selectedId, setSelectedId] = useState<string | undefined>()
  const [panelOpen, setPanelOpen] = useState(false)
  const [sortField, setSortField] = useState<string>('startTime')
@@ -414,95 +416,128 @@ export default function Dashboard() {
      {/* Shortcuts bar */}
      <ShortcutsBar shortcuts={SHORTCUTS} />

-      {/* Detail panel */}
-      {selectedRow && detail && (
-        <DetailPanel
-          open={panelOpen}
-          onClose={() => setPanelOpen(false)}
-          title={`${detail.routeId} \u2014 ${selectedRow.executionId.slice(0, 12)}`}
-        >
-          {/* Link to full detail page */}
-          <div className={styles.panelSection}>
-            <button
-              className={styles.openDetailLink}
-              onClick={() => navigate(`/exchanges/${detail.executionId}`)}
-            >
-              Open full details &#x2192;
-            </button>
-          </div>
-
-          {/* Overview */}
-          <div className={styles.panelSection}>
-            <div className={styles.panelSectionTitle}>Overview</div>
-            <div className={styles.overviewGrid}>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Status</span>
-                <span className={styles.statusCell}>
-                  <StatusDot variant={statusToVariant(detail.status)} />
-                  <span>{statusLabel(detail.status)}</span>
-                </span>
-              </div>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Duration</span>
-                <MonoText size="sm">{formatDuration(detail.durationMs)}</MonoText>
-              </div>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Route</span>
-                <span>{detail.routeId}</span>
-              </div>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Agent</span>
-                <MonoText size="sm">{detail.agentId ?? '\u2014'}</MonoText>
-              </div>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Correlation</span>
-                <MonoText size="xs">{detail.correlationId ?? '\u2014'}</MonoText>
-              </div>
-              <div className={styles.overviewRow}>
-                <span className={styles.overviewLabel}>Timestamp</span>
-                <MonoText size="xs">{detail.startTime ? new Date(detail.startTime).toISOString() : '\u2014'}</MonoText>
-              </div>
-            </div>
-          </div>
-
-          {/* Errors */}
-          {errorMsg && (
-            <div className={styles.panelSection}>
-              <div className={styles.panelSectionTitle}>Errors</div>
-              <div className={styles.errorBlock}>
-                <div className={styles.errorClass}>{errorClass}</div>
-                <div className={styles.errorMessage}>{errorMsg}</div>
-              </div>
-            </div>
-          )}
-
-          {/* Route Flow */}
-          <div className={styles.panelSection}>
-            <div className={styles.panelSectionTitle}>Route Flow</div>
-            {routeNodes.length > 0 ? (
-              <RouteFlow nodes={routeNodes} />
-            ) : (
-              <div style={{ color: 'var(--text-muted)', fontSize: 12 }}>No diagram available</div>
-            )}
-          </div>
-
-          {/* Processor Timeline */}
-          <div className={styles.panelSection}>
-            <div className={styles.panelSectionTitle}>
-              Processor Timeline
-              <span className={styles.panelSectionMeta}>{formatDuration(detail.durationMs)}</span>
-            </div>
-            {flatProcs.length > 0 ? (
-              <ProcessorTimeline
-                processors={flatProcs}
-                totalMs={detail.durationMs}
-              />
-            ) : (
-              <div style={{ color: 'var(--text-muted)', fontSize: 12 }}>No processor data</div>
-            )}
-          </div>
-        </DetailPanel>
-      )}
+      {/* Detail panel — hoisted to AppShell via context */}
+      <DashboardDetailPanel
+        open={panelOpen}
+        onClose={() => setPanelOpen(false)}
+        selectedRow={selectedRow}
+        detail={detail}
+        errorClass={errorClass}
+        errorMsg={errorMsg}
+        routeNodes={routeNodes}
+        flatProcs={flatProcs}
+        navigate={navigate}
+        setDetail={setDetail}
+      />
    </>
  )
 }
+
+/** Renders the DetailPanel into the AppShell detail slot via context. */
+function DashboardDetailPanel({
+  open, onClose, selectedRow, detail, errorClass, errorMsg, routeNodes, flatProcs, navigate, setDetail,
+}: {
+  open: boolean
+  onClose: () => void
+  selectedRow: Row | undefined
+  detail: any
+  errorClass: string
+  errorMsg: string
+  routeNodes: RouteNode[]
+  flatProcs: any[]
+  navigate: (path: string) => void
+  setDetail: (node: React.ReactNode) => void
+}) {
+  useEffect(() => {
+    if (!selectedRow || !detail) {
+      setDetail(null)
+      return
+    }
+    setDetail(
+      <DetailPanel
+        open={open}
+        onClose={onClose}
+        title={`${detail.routeId} \u2014 ${selectedRow.executionId.slice(0, 12)}`}
+      >
+        <div className={styles.panelSection}>
+          <button
+            className={styles.openDetailLink}
+            onClick={() => navigate(`/exchanges/${detail.executionId}`)}
+          >
+            Open full details &#x2192;
+          </button>
+        </div>
+
+        <div className={styles.panelSection}>
+          <div className={styles.panelSectionTitle}>Overview</div>
+          <div className={styles.overviewGrid}>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Status</span>
+              <span className={styles.statusCell}>
+                <StatusDot variant={statusToVariant(detail.status)} />
+                <span>{statusLabel(detail.status)}</span>
+              </span>
+            </div>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Duration</span>
+              <MonoText size="sm">{formatDuration(detail.durationMs)}</MonoText>
+            </div>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Route</span>
+              <span>{detail.routeId}</span>
+            </div>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Agent</span>
+              <MonoText size="sm">{detail.agentId ?? '\u2014'}</MonoText>
+            </div>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Correlation</span>
+              <MonoText size="xs">{detail.correlationId ?? '\u2014'}</MonoText>
+            </div>
+            <div className={styles.overviewRow}>
+              <span className={styles.overviewLabel}>Timestamp</span>
+              <MonoText size="xs">{detail.startTime ? new Date(detail.startTime).toISOString() : '\u2014'}</MonoText>
+            </div>
+          </div>
+        </div>
+
+        {errorMsg && (
+          <div className={styles.panelSection}>
+            <div className={styles.panelSectionTitle}>Errors</div>
+            <div className={styles.errorBlock}>
+              <div className={styles.errorClass}>{errorClass}</div>
+              <div className={styles.errorMessage}>{errorMsg}</div>
+            </div>
+          </div>
+        )}
+
+        <div className={styles.panelSection}>
+          <div className={styles.panelSectionTitle}>Route Flow</div>
+          {routeNodes.length > 0 ? (
+            <RouteFlow nodes={routeNodes} />
+          ) : (
+            <div style={{ color: 'var(--text-muted)', fontSize: 12 }}>No diagram available</div>
+          )}
+        </div>
+
+        <div className={styles.panelSection}>
+          <div className={styles.panelSectionTitle}>
+            Processor Timeline
+            <span className={styles.panelSectionMeta}>{formatDuration(detail.durationMs)}</span>
+          </div>
+          {flatProcs.length > 0 ? (
+            <ProcessorTimeline
+              processors={flatProcs}
+              totalMs={detail.durationMs}
+            />
+          ) : (
+            <div style={{ color: 'var(--text-muted)', fontSize: 12 }}>No processor data</div>
+          )}
+        </div>
+      </DetailPanel>
+    )
+    return () => setDetail(null)
+  })
+
+  return null
+}