cameleer/cameleer-server
1
0
Fork 0
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

test(deploy): autowire repository in snapshot IT (JavaTimeModule-safe)

Browse Source 
Replace manual `new PostgresDeploymentRepository(jdbcTemplate, new ObjectMapper())` with
`@Autowired PostgresDeploymentRepository repository` to use the Spring-managed bean whose
ObjectMapper has JavaTimeModule registered. Also removes the redundant isNotNull() assertion
whose work is done by the field-level assertions that follow.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
hsiegeln
2026-04-22 21:43:40 +02:00
parent d3e86b9d77
commit 9b851c4622
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cameleer-server-app/src/test/java/com/cameleer/server/app/storage/PostgresDeploymentRepositoryIT.java
View File

@@ -4,10 +4,10 @@ import com.cameleer.common.model.ApplicationConfig;
import com.cameleer.server.app.AbstractPostgresIT; import com.cameleer.server.app.AbstractPostgresIT;
import com.cameleer.server.core.runtime.Deployment; import com.cameleer.server.core.runtime.Deployment;
import com.cameleer.server.core.runtime.DeploymentConfigSnapshot; import com.cameleer.server.core.runtime.DeploymentConfigSnapshot;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import java.util.Map; import java.util.Map;
import java.util.UUID; import java.util.UUID;
@@ -16,7 +16,7 @@ import static org.assertj.core.api.Assertions.assertThat;
class PostgresDeploymentRepositoryIT extends AbstractPostgresIT { class PostgresDeploymentRepositoryIT extends AbstractPostgresIT {
private PostgresDeploymentRepository repository; @Autowired PostgresDeploymentRepository repository;
private UUID envId; private UUID envId;
private UUID appId; private UUID appId;
@@ -24,8 +24,6 @@ class PostgresDeploymentRepositoryIT extends AbstractPostgresIT {
@BeforeEach @BeforeEach
void setup() { void setup() {
repository = new PostgresDeploymentRepository(jdbcTemplate, new ObjectMapper());
envId = UUID.randomUUID(); envId = UUID.randomUUID();
jdbcTemplate.update( jdbcTemplate.update(
"INSERT INTO environments (id, slug, display_name) VALUES (?, ?, ?)", "INSERT INTO environments (id, slug, display_name) VALUES (?, ?, ?)",
@@ -73,7 +71,6 @@ class PostgresDeploymentRepositoryIT extends AbstractPostgresIT {
Deployment loaded = repository.findById(deploymentId).orElseThrow(); Deployment loaded = repository.findById(deploymentId).orElseThrow();
// then // then
assertThat(loaded.deployedConfigSnapshot()).isNotNull();
assertThat(loaded.deployedConfigSnapshot().jarVersionId()).isEqualTo(jarVersionId); assertThat(loaded.deployedConfigSnapshot().jarVersionId()).isEqualTo(jarVersionId);
assertThat(loaded.deployedConfigSnapshot().agentConfig().getSamplingRate()).isEqualTo(0.5); assertThat(loaded.deployedConfigSnapshot().agentConfig().getSamplingRate()).isEqualTo(0.5);
assertThat(loaded.deployedConfigSnapshot().containerConfig()).containsEntry("memoryLimitMb", 1024); assertThat(loaded.deployedConfigSnapshot().containerConfig()).containsEntry("memoryLimitMb", 1024);