diff --git a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/ConfigPanel.test.tsx b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/ConfigPanel.test.tsx index 1cd68175..bd03a27a 100644 --- a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/ConfigPanel.test.tsx +++ b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/ConfigPanel.test.tsx @@ -66,7 +66,7 @@ describe('ConfigPanel', () => { }, resources: { memoryLimit: '256', memoryReserve: '', cpuRequest: '500', cpuLimit: '', - ports: [], appPort: '8080', replicas: '1', deployStrategy: 'blue-green', + appPort: '8080', replicas: '1', deployStrategy: 'blue-green', stripPrefix: true, sslOffloading: true, runtimeType: 'auto', customArgs: '', extraNetworks: [], }, diff --git a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.test.ts b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.test.ts index bb0328a1..f527cfc6 100644 --- a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.test.ts +++ b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.test.ts @@ -28,7 +28,6 @@ describe('snapshotToForm', () => { replicas: 3, deploymentStrategy: 'rolling', customEnvVars: { FOO: 'bar', BAZ: 'qux' }, - exposedPorts: [8080, 9090], }, sensitiveKeys: ['SECRET_KEY'], }; @@ -36,7 +35,6 @@ describe('snapshotToForm', () => { expect(result.resources.memoryLimit).toBe('1024'); expect(result.resources.replicas).toBe('3'); expect(result.resources.deployStrategy).toBe('rolling'); - expect(result.resources.ports).toEqual([8080, 9090]); expect(result.variables.envVars).toEqual([ { key: 'FOO', value: 'bar' }, { key: 'BAZ', value: 'qux' }, diff --git a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.ts b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.ts index 4c3d64b6..1c00320a 100644 --- a/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.ts +++ b/ui/src/pages/AppsTab/AppDeploymentPage/CheckpointDetailDrawer/snapshotToForm.ts @@ -36,7 +36,6 @@ export function snapshotToForm( memoryReserve: c.memoryReserveMb != null ? String(c.memoryReserveMb) : defaults.resources.memoryReserve, cpuRequest: c.cpuRequest !== undefined ? String(c.cpuRequest) : defaults.resources.cpuRequest, cpuLimit: c.cpuLimit != null ? String(c.cpuLimit) : defaults.resources.cpuLimit, - ports: Array.isArray(c.exposedPorts) ? (c.exposedPorts as number[]) : defaults.resources.ports, appPort: c.appPort !== undefined ? String(c.appPort) : defaults.resources.appPort, replicas: c.replicas !== undefined ? String(c.replicas) : defaults.resources.replicas, deployStrategy: (c.deploymentStrategy as string) ?? defaults.resources.deployStrategy, diff --git a/ui/src/pages/AppsTab/AppDeploymentPage/ConfigTabs/ResourcesTab.tsx b/ui/src/pages/AppsTab/AppDeploymentPage/ConfigTabs/ResourcesTab.tsx index 458ddc6f..fae0cfc3 100644 --- a/ui/src/pages/AppsTab/AppDeploymentPage/ConfigTabs/ResourcesTab.tsx +++ b/ui/src/pages/AppsTab/AppDeploymentPage/ConfigTabs/ResourcesTab.tsx @@ -11,24 +11,11 @@ interface Props { } export function ResourcesTab({ value, onChange, disabled, isProd = false }: Props) { - const [newPort, setNewPort] = useState(''); const [newNetwork, setNewNetwork] = useState(''); const update = (key: K, v: ResourcesFormState[K]) => onChange({ ...value, [key]: v }); - function addPort() { - const p = parseInt(newPort); - if (p && !value.ports.includes(p)) { - onChange({ ...value, ports: [...value.ports, p] }); - setNewPort(''); - } - } - - function removePort(port: number) { - if (!disabled) update('ports', value.ports.filter((x) => x !== port)); - } - function addNetwork() { const v = newNetwork.trim(); if (v && !value.extraNetworks.includes(v)) { @@ -123,35 +110,6 @@ export function ResourcesTab({ value, onChange, disabled, isProd = false }: Prop millicores - Exposed Ports -
- {value.ports.map((p) => ( - - {p} - - - ))} - setNewPort(e.target.value)} - onKeyDown={(e) => { - if (e.key === 'Enter') { - e.preventDefault(); - addPort(); - } - }} - /> -
- App Port v.key.trim()).map((v) => [v.key, v.value]), ),