fix: resolve 25 SonarQube code smells across 21 files
All checks were successful
CI / cleanup-branch (push) Has been skipped
CI / build (push) Successful in 1m2s
CI / docker (push) Successful in 45s
CI / deploy-feature (push) Has been skipped
CI / deploy (push) Successful in 38s

Remove unused fields (log, rbacService, roleRepository, jwt),
unused variables (agentTps, routeKeys, updated), unused imports
(HttpHeaders, JdbcTemplate). Rename restricted identifier 'record'
to 'auditRecord'/'event'. Return empty collections instead of null.
Replace .collect(Collectors.toList()) with .toList(). Simplify
conditional return in BootstrapTokenValidator.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
hsiegeln
2026-04-04 09:36:13 +02:00
parent 633a61d89d
commit b04b12220b
21 changed files with 42 additions and 90 deletions

View File

@@ -31,20 +31,12 @@ public class BootstrapTokenValidator {
byte[] providedBytes = provided.getBytes(StandardCharsets.UTF_8);
// Check current token
// Check current token, then previous token (rotation support)
String currentToken = properties.getBootstrapToken();
if (currentToken != null
&& MessageDigest.isEqual(providedBytes, currentToken.getBytes(StandardCharsets.UTF_8))) {
return true;
}
// Check previous token (rotation support)
String previousToken = properties.getBootstrapTokenPrevious();
if (previousToken != null
&& MessageDigest.isEqual(providedBytes, previousToken.getBytes(StandardCharsets.UTF_8))) {
return true;
}
return false;
return (currentToken != null
&& MessageDigest.isEqual(providedBytes, currentToken.getBytes(StandardCharsets.UTF_8)))
|| (previousToken != null
&& MessageDigest.isEqual(providedBytes, previousToken.getBytes(StandardCharsets.UTF_8)));
}
}