fix(deploy): address final review — sensitiveKeys snapshot, dirty scrubbing, transition race, refetch invalidations
- Issue 1: add List<String> sensitiveKeys as 4th field to DeploymentConfigSnapshot; populate from agentConfig.getSensitiveKeys() in DeploymentExecutor; handleRestore hydrates from snap.sensitiveKeys directly; Deployment type in apps.ts gains sensitiveKeys field - Issue 2: after createApp succeeds, refetchQueries(['apps', envSlug]) before navigate so the new app is in cache before the router renders the deployed view (eliminates transient Save- disabled flash) - Issue 3: useDeploymentPageState useEffect now uses prevServerStateRef to detect local edits; background refetches only overwrite form when no local changes are present - Issue 5: handleRedeploy invalidates dirty-state + versions queries after createDeployment resolves; handleSave invalidates dirty-state after staged save - Issue 10: DirtyStateCalculator strips volatile agentConfig keys (version, updatedAt, updatedBy, environment, application) before JSON comparison via scrubAgentConfig(); adds versionBumpDoesNotMarkDirty test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
// ui/src/pages/AppsTab/AppDeploymentPage/hooks/useDeploymentPageState.ts
|
||||
import { useState, useEffect, useMemo } from 'react';
|
||||
import { useState, useEffect, useMemo, useRef } from 'react';
|
||||
import type { ApplicationConfig } from '../../../../api/queries/commands';
|
||||
import type { App } from '../../../../api/queries/admin/apps';
|
||||
|
||||
@@ -115,9 +115,18 @@ export function useDeploymentPageState(
|
||||
}, [app, agentConfig, envDefaults]);
|
||||
|
||||
const [form, setForm] = useState<DeploymentPageFormState>(serverState);
|
||||
const prevServerStateRef = useRef<DeploymentPageFormState>(serverState);
|
||||
|
||||
useEffect(() => {
|
||||
setForm(serverState);
|
||||
// Only overwrite form if the current form value still matches the previous
|
||||
// server state (i.e., the user has no local edits). Otherwise preserve
|
||||
// user edits through background refetches.
|
||||
setForm((current) => {
|
||||
const hadLocalEdits =
|
||||
JSON.stringify(current) !== JSON.stringify(prevServerStateRef.current);
|
||||
prevServerStateRef.current = serverState;
|
||||
return hadLocalEdits ? current : serverState;
|
||||
});
|
||||
}, [serverState]);
|
||||
|
||||
return { form, setForm, reset: () => setForm(serverState), serverState };
|
||||
|
||||
Reference in New Issue
Block a user