From ed0e616109019899fd8ae41a99f67dcae12ddf89 Mon Sep 17 00:00:00 2001 From: hsiegeln <37154749+hsiegeln@users.noreply.github.com> Date: Thu, 23 Apr 2026 12:52:18 +0200 Subject: [PATCH] refactor(logs): drop dead null guards on instanceIds filter (record normalizes) --- .../com/cameleer/server/app/search/ClickHouseLogStore.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cameleer-server-app/src/main/java/com/cameleer/server/app/search/ClickHouseLogStore.java b/cameleer-server-app/src/main/java/com/cameleer/server/app/search/ClickHouseLogStore.java index ce932c3e..a389e28e 100644 --- a/cameleer-server-app/src/main/java/com/cameleer/server/app/search/ClickHouseLogStore.java +++ b/cameleer-server-app/src/main/java/com/cameleer/server/app/search/ClickHouseLogStore.java @@ -122,7 +122,7 @@ public class ClickHouseLogStore implements LogIndex { baseParams.add(request.instanceId()); } - if (request.instanceIds() != null && !request.instanceIds().isEmpty()) { + if (!request.instanceIds().isEmpty()) { String placeholders = String.join(", ", Collections.nCopies(request.instanceIds().size(), "?")); baseConditions.add("instance_id IN (" + placeholders + ")"); for (String id : request.instanceIds()) { @@ -289,7 +289,7 @@ public class ClickHouseLogStore implements LogIndex { params.add(request.instanceId()); } - if (request.instanceIds() != null && !request.instanceIds().isEmpty()) { + if (!request.instanceIds().isEmpty()) { String placeholders = String.join(", ", Collections.nCopies(request.instanceIds().size(), "?")); conditions.add("instance_id IN (" + placeholders + ")"); for (String id : request.instanceIds()) {