Merge pull request 'fix(alerting): ClickHouseSearchIndex bean registered as concrete type (hotfix: production crashloop)' (#141 ) from fix/alerting-searchindex-bean-type into main

Reviewed-on: #141
fix(alerting): declare ClickHouseSearchIndex bean as concrete type
2026-04-20 10:24:49 +02:00 · 2026-04-20 09:11:47 +02:00
1 changed files with 6 additions and 1 deletions
--- a/cameleer-server-app/src/main/java/com/cameleer/server/app/config/StorageBeanConfig.java
+++ b/cameleer-server-app/src/main/java/com/cameleer/server/app/config/StorageBeanConfig.java
@@ -123,9 +123,14 @@ public class StorageBeanConfig {
    }

    @Bean
-    public SearchIndex clickHouseSearchIndex(
+    public ClickHouseSearchIndex clickHouseSearchIndex(
            TenantProperties tenantProperties,
            @Qualifier("clickHouseJdbcTemplate") JdbcTemplate clickHouseJdbc) {
+        // Return type is the concrete class so Spring exposes the bean under both
+        // SearchIndex (for SearchIndexer) AND ClickHouseSearchIndex (for ExchangeMatchEvaluator,
+        // which calls countExecutionsForAlerting — a method that exists only on the concrete type).
+        // Declaring the return as the interface hides the concrete methods from autowire
+        // matching and crashloops the app on startup.
        return new ClickHouseSearchIndex(tenantProperties.getId(), clickHouseJdbc);
    }
Author	SHA1	Message	Date
hsiegeln	5373ac6541	Merge pull request 'fix(alerting): ClickHouseSearchIndex bean registered as concrete type (hotfix: production crashloop)' (#141 ) from fix/alerting-searchindex-bean-type into main All checks were successful CI / cleanup-branch (push) Has been skipped Details CI / build (push) Successful in 1m53s Details CI / docker (push) Successful in 31s Details CI / deploy-feature (push) Has been skipped Details CI / deploy (push) Successful in 42s Details Reviewed-on: #141	2026-04-20 10:24:49 +02:00
hsiegeln	c9c93ac565	fix(alerting): declare ClickHouseSearchIndex bean as concrete type All checks were successful CI / cleanup-branch (push) Has been skipped Details CI / build (push) Successful in 3m6s Details CI / cleanup-branch (pull_request) Has been skipped Details CI / build (pull_request) Successful in 4m5s Details CI / docker (pull_request) Has been skipped Details CI / deploy (pull_request) Has been skipped Details CI / deploy-feature (pull_request) Has been skipped Details CI / docker (push) Successful in 1m37s Details CI / deploy (push) Has been skipped Details CI / deploy-feature (push) Successful in 39s Details Production crashlooped on startup: ExchangeMatchEvaluator autowires the concrete ClickHouseSearchIndex (for countExecutionsForAlerting, which lives only on the concrete class, not the SearchIndex interface), but StorageBeanConfig declared the bean with interface return type SearchIndex. Spring matches autowire candidates by declared bean type, not by runtime instance class, so the concrete-typed autowire failed with: Parameter 0 of constructor in ExchangeMatchEvaluator required a bean of type 'ClickHouseSearchIndex' that could not be found. ClickHouseLogStore's bean is already declared with the concrete return type (line 171), which is why LogPatternEvaluator autowires fine. All alerting ITs passed pre-merge because AbstractPostgresIT replaces the clickHouseSearchIndex bean with @MockBean(name=...) whose declared type IS the concrete ClickHouseSearchIndex. The mock masked the prod bug. Follow-up: remove @MockBean(name="clickHouseSearchIndex") from AbstractPostgresIT so the real bean graph is exercised by alerting ITs (and add a SpringContextSmokeIT that loads the context with no mocks). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-20 09:11:47 +02:00