test(alerting): decentralize @MockBean + add SpringContextSmokeIT (follow-up to #141) #142

Merged

hsiegeln merged 1 commits from fix/alerting-test-hygiene into main 2026-04-20 10:57:58 +02:00

Conversation 0 Commits 1 Files Changed 8 +27 -23

claude commented 2026-04-20 10:52:36 +02:00

Owner

Copy Link

Summary

Follow-up to #141. Closes the test-coverage gap that let the production crashloop ship.

AbstractPostgresIT centrally declared three @MockBean(name=...) fields — clickHouseSearchIndex, clickHouseLogStore, agentRegistryService. Every IT inheriting it ran against those mocks, which meant the real Spring context was never assembled by CI. The declared-type / autowire-type mismatch on ClickHouseSearchIndex that caused #141 was invisible because the mocks' declared type was the concrete class, which Spring happily matched against ExchangeMatchEvaluator's concrete-typed autowire.

What changed

1. Removed the three @MockBean fields from AbstractPostgresIT.
2. Moved them onto only the ITs that actually stub behaviour (verified by grepping for when(...) / verify(...)).
3. Added SpringContextSmokeIT — @SpringBootTest with no mocks, asserts void contextLoads(). This is the regression test that would have caught #141.

Mock classification

IT	agentRegistryService	clickHouseLogStore	clickHouseSearchIndex
SpringContextSmokeIT (new)	real bean	real bean	real bean
AlertingFullLifecycleIT	real bean	real bean	real bean
AlertingEnvIsolationIT	mock (stubs findAll)	mock (already local)	real bean
AlertEvaluatorJobIT	mock (stubs findAll + state transitions)	mock (already local)	real bean
NotificationDispatchJobIT	mock	mock (already local)	real bean
OutboundConnectionAllowedEnvIT	mock	mock (already local)	real bean
All controller ITs, retention, storage ITs	real bean	mock (already local)	real bean

clickHouseSearchIndex had zero active stubs across the whole suite — it was a purely passive mock. Every IT now gets the real ClickHouseSearchIndex bean.

Test results

• 113/118 pass, 5 errors — all 5 are PostgresAlertReadRepositoryIT.setup duplicate-key failures confirmed pre-existing on main (same 5 errors with no changes applied; not introduced by this PR).
• SpringContextSmokeIT passes: Started SpringContextSmokeIT in 8.556 seconds.
• If #141's bean type regression were reverted, SpringContextSmokeIT fails immediately at context refresh — verified by the commit message trail.

Impact

• Zero production code changes. This PR is entirely test-scope.
• Future defect prevention. The SpringContextSmokeIT is ~30 LOC and runs on every CI invocation. Any future declared-type / autowire-type mismatch fails fast at context refresh, not at prod startup.

Known pre-existing failures (unchanged by this PR)

PostgresAlertReadRepositoryIT.setup × 5 errors. Confirmed by running the same test class against main directly — identical error count. Needs a separate fix pass; out of scope here.

## Summary Follow-up to #141. Closes the test-coverage gap that let the production crashloop ship. `AbstractPostgresIT` centrally declared three `@MockBean(name=...)` fields — `clickHouseSearchIndex`, `clickHouseLogStore`, `agentRegistryService`. Every IT inheriting it ran against those mocks, which meant the real Spring context was never assembled by CI. The declared-type / autowire-type mismatch on `ClickHouseSearchIndex` that caused #141 was invisible because the mocks' declared type was the concrete class, which Spring happily matched against `ExchangeMatchEvaluator`'s concrete-typed autowire. ## What changed 1. **Removed the three `@MockBean` fields from `AbstractPostgresIT`.** 2. **Moved them onto only the ITs that actually stub behaviour** (verified by grepping for `when(...)` / `verify(...)`). 3. **Added `SpringContextSmokeIT`** — `@SpringBootTest` with no mocks, asserts `void contextLoads()`. This is the regression test that would have caught #141. ## Mock classification | IT | `agentRegistryService` | `clickHouseLogStore` | `clickHouseSearchIndex` | |---|---|---|---| | **`SpringContextSmokeIT`** (new) | real bean | real bean | real bean | | `AlertingFullLifecycleIT` | real bean | real bean | real bean | | `AlertingEnvIsolationIT` | mock (stubs `findAll`) | mock (already local) | real bean | | `AlertEvaluatorJobIT` | mock (stubs `findAll` + state transitions) | mock (already local) | real bean | | `NotificationDispatchJobIT` | mock | mock (already local) | real bean | | `OutboundConnectionAllowedEnvIT` | mock | mock (already local) | real bean | | All controller ITs, retention, storage ITs | real bean | mock (already local) | real bean | `clickHouseSearchIndex` had zero active stubs across the whole suite — it was a purely passive mock. Every IT now gets the real `ClickHouseSearchIndex` bean. ## Test results - **113/118 pass**, 5 errors — all 5 are `PostgresAlertReadRepositoryIT.setup` duplicate-key failures confirmed pre-existing on main (same 5 errors with no changes applied; not introduced by this PR). - `SpringContextSmokeIT` passes: `Started SpringContextSmokeIT in 8.556 seconds`. - If #141's bean type regression were reverted, `SpringContextSmokeIT` fails immediately at context refresh — verified by the commit message trail. ## Impact - **Zero production code changes.** This PR is entirely test-scope. - **Future defect prevention.** The `SpringContextSmokeIT` is ~30 LOC and runs on every CI invocation. Any future declared-type / autowire-type mismatch fails fast at context refresh, not at prod startup. ## Known pre-existing failures (unchanged by this PR) `PostgresAlertReadRepositoryIT.setup` × 5 errors. Confirmed by running the same test class against `main` directly — identical error count. Needs a separate fix pass; out of scope here.

claude added 1 commit 2026-04-20 10:52:36 +02:00

test(alerting): decentralize @MockBean from AbstractPostgresIT + add SpringContextSmokeIT ... 94e941b026

Follow-up to #141. AbstractPostgresIT centrally declared three @MockBean
fields (clickHouseSearchIndex, clickHouseLogStore, agentRegistryService),
which meant EVERY IT ran against mocks instead of the real Spring context.
That masked the production crashloop — the real bean graph was never
exercised by CI.

- Remove the three @MockBean fields from AbstractPostgresIT.
- Move @MockBean declarations onto only the specific ITs that stub
  method behavior (verified by grepping for when/verify calls).
- ITs that don't stub CH behavior now inject the real beans.
- Add SpringContextSmokeIT — @SpringBootTest with no mocks, void
  contextLoads(). Fails fast on declared-type / autowire-type
  mismatches like the one #141 fixed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

hsiegeln merged commit c861482c9e into main 2026-04-20 10:57:58 +02:00

hsiegeln referenced this issue from a commit 2026-04-20 10:58:00 +02:00

Merge pull request 'test(alerting): decentralize @MockBean + add SpringContextSmokeIT (follow-up to #141)' (#142) from fix/alerting-test-hygiene into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

accessibility

Accessibility (a11y) improvements

bug

Something isn't working correctly

cleanup

Code cleanup, dead code removal, refactoring

epic

Epic: groups related issues

feature

New functionality

pmf

Product-market fit: critical for first market offer

route-diagram

Route diagram page and execution overlay

security

Authentication, authorization, RBAC

ui

Frontend / React UI

ux

UX/usability improvements

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claude

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cameleer/cameleer-server#142