refactor: use SplitPane and EntityList in Admin RBAC tabs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
hsiegeln
@@ -7,6 +7,8 @@ import { MonoText } from '../../../design-system/primitives/MonoText/MonoText'
|
||||
import { SectionHeader } from '../../../design-system/primitives/SectionHeader/SectionHeader'
|
||||
import { Tag } from '../../../design-system/primitives/Tag/Tag'
|
||||
import { ConfirmDialog } from '../../../design-system/composites/ConfirmDialog/ConfirmDialog'
|
||||
import { SplitPane } from '../../../design-system/composites/SplitPane/SplitPane'
|
||||
import { EntityList } from '../../../design-system/composites/EntityList/EntityList'
|
||||
import { useToast } from '../../../design-system/composites/Toast/Toast'
|
||||
import { MOCK_ROLES, MOCK_GROUPS, MOCK_USERS, getEffectiveRoles, type MockRole } from './rbacMocks'
|
||||
import styles from './UserManagement.module.css'
|
||||
@@ -79,141 +81,124 @@ export function RolesTab() {
|
||||
|
||||
return (
|
||||
<>
|
||||
<div className={styles.splitPane}>
|
||||
<div className={styles.listPane}>
|
||||
<div className={styles.listHeader}>
|
||||
<Input
|
||||
placeholder="Search roles..."
|
||||
value={search}
|
||||
onChange={(e) => setSearch(e.target.value)}
|
||||
onClear={() => setSearch('')}
|
||||
className={styles.listHeaderSearch}
|
||||
/>
|
||||
<Button size="sm" variant="secondary" onClick={() => setCreating(true)}>
|
||||
+ Add role
|
||||
</Button>
|
||||
</div>
|
||||
|
||||
{creating && (
|
||||
<div className={styles.createForm}>
|
||||
<Input placeholder="Role name *" value={newName} onChange={(e) => setNewName(e.target.value)} />
|
||||
{duplicateRoleName && <span style={{ color: 'var(--error)', fontSize: 11 }}>Role name already exists</span>}
|
||||
<Input placeholder="Description" value={newDesc} onChange={(e) => setNewDesc(e.target.value)} />
|
||||
<div className={styles.createFormActions}>
|
||||
<Button size="sm" variant="ghost" onClick={() => setCreating(false)}>Cancel</Button>
|
||||
<Button size="sm" variant="primary" onClick={handleCreate} disabled={!newName.trim() || duplicateRoleName}>Create</Button>
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
<div className={styles.entityList} role="listbox" aria-label="Roles">
|
||||
{filtered.map((role) => (
|
||||
<div
|
||||
key={role.id}
|
||||
className={`${styles.entityItem} ${selectedId === role.id ? styles.entityItemSelected : ''}`}
|
||||
onClick={() => setSelectedId(role.id)}
|
||||
role="option"
|
||||
tabIndex={0}
|
||||
aria-selected={selectedId === role.id}
|
||||
onKeyDown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); setSelectedId(role.id) } }}
|
||||
>
|
||||
<Avatar name={role.name} size="sm" />
|
||||
<div className={styles.entityInfo}>
|
||||
<div className={styles.entityName}>
|
||||
{role.name}
|
||||
{role.system && <Badge label="system" color="auto" variant="outlined" className={styles.providerBadge} />}
|
||||
</div>
|
||||
<div className={styles.entityMeta}>
|
||||
{role.description} · {getAssignmentCount(role)} assignments
|
||||
</div>
|
||||
<div className={styles.entityTags}>
|
||||
{MOCK_GROUPS.filter((g) => g.directRoles.includes(role.name))
|
||||
.map((g) => <Badge key={g.id} label={g.name} color="success" />)}
|
||||
{MOCK_USERS.filter((u) => u.directRoles.includes(role.name))
|
||||
.map((u) => <Badge key={u.id} label={u.username} color="auto" />)}
|
||||
</div>
|
||||
<SplitPane
|
||||
list={
|
||||
<>
|
||||
{creating && (
|
||||
<div className={styles.createForm}>
|
||||
<Input placeholder="Role name *" value={newName} onChange={(e) => setNewName(e.target.value)} />
|
||||
{duplicateRoleName && <span style={{ color: 'var(--error)', fontSize: 11 }}>Role name already exists</span>}
|
||||
<Input placeholder="Description" value={newDesc} onChange={(e) => setNewDesc(e.target.value)} />
|
||||
<div className={styles.createFormActions}>
|
||||
<Button size="sm" variant="ghost" onClick={() => setCreating(false)}>Cancel</Button>
|
||||
<Button size="sm" variant="primary" onClick={handleCreate} disabled={!newName.trim() || duplicateRoleName}>Create</Button>
|
||||
</div>
|
||||
</div>
|
||||
))}
|
||||
{filtered.length === 0 && (
|
||||
<div className={styles.emptySearch}>No roles match your search</div>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div className={styles.detailPane}>
|
||||
{selected ? (
|
||||
<>
|
||||
<div className={styles.detailHeader}>
|
||||
<Avatar name={selected.name} size="lg" />
|
||||
<div className={styles.detailHeaderInfo}>
|
||||
<div className={styles.detailName}>{selected.name}</div>
|
||||
{selected.description && (
|
||||
<div className={styles.detailEmail}>{selected.description}</div>
|
||||
)}
|
||||
</div>
|
||||
{!selected.system && (
|
||||
<Button
|
||||
size="sm"
|
||||
variant="danger"
|
||||
onClick={() => setDeleteTarget(selected)}
|
||||
>
|
||||
Delete
|
||||
</Button>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<div className={styles.metaGrid}>
|
||||
<span className={styles.metaLabel}>ID</span>
|
||||
<MonoText size="xs">{selected.id}</MonoText>
|
||||
<span className={styles.metaLabel}>Scope</span>
|
||||
<span className={styles.metaValue}>{selected.scope}</span>
|
||||
{selected.system && (
|
||||
<>
|
||||
<span className={styles.metaLabel}>Type</span>
|
||||
<span className={styles.metaValue}>System role (read-only)</span>
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Assigned to groups</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{assignedGroups.map((g) => <Tag key={g.id} label={g.name} color="success" />)}
|
||||
{assignedGroups.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Assigned to users (direct)</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{directUsers.map((u) => <Tag key={u.id} label={u.displayName} color="auto" />)}
|
||||
{directUsers.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Effective principals</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{effectivePrincipals.map((u) => {
|
||||
const isDirect = u.directRoles.includes(selected.name)
|
||||
return (
|
||||
<Badge
|
||||
key={u.id}
|
||||
label={u.displayName}
|
||||
color="auto"
|
||||
variant={isDirect ? 'filled' : 'dashed'}
|
||||
/>
|
||||
)
|
||||
})}
|
||||
{effectivePrincipals.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
{effectivePrincipals.some((u) => !u.directRoles.includes(selected.name)) && (
|
||||
<span className={styles.inheritedNote}>
|
||||
Dashed entries inherit this role through group membership
|
||||
</span>
|
||||
<EntityList
|
||||
items={filtered}
|
||||
renderItem={(role) => (
|
||||
<>
|
||||
<Avatar name={role.name} size="sm" />
|
||||
<div className={styles.entityInfo}>
|
||||
<div className={styles.entityName}>
|
||||
{role.name}
|
||||
{role.system && <Badge label="system" color="auto" variant="outlined" className={styles.providerBadge} />}
|
||||
</div>
|
||||
<div className={styles.entityMeta}>
|
||||
{role.description} · {getAssignmentCount(role)} assignments
|
||||
</div>
|
||||
<div className={styles.entityTags}>
|
||||
{MOCK_GROUPS.filter((g) => g.directRoles.includes(role.name))
|
||||
.map((g) => <Badge key={g.id} label={g.name} color="success" />)}
|
||||
{MOCK_USERS.filter((u) => u.directRoles.includes(role.name))
|
||||
.map((u) => <Badge key={u.id} label={u.username} color="auto" />)}
|
||||
</div>
|
||||
</div>
|
||||
</>
|
||||
)}
|
||||
</>
|
||||
) : (
|
||||
<div className={styles.emptyDetail}>Select a role to view details</div>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
getItemId={(role) => role.id}
|
||||
selectedId={selectedId ?? undefined}
|
||||
onSelect={setSelectedId}
|
||||
searchPlaceholder="Search roles..."
|
||||
onSearch={setSearch}
|
||||
addLabel="+ Add role"
|
||||
onAdd={() => setCreating(true)}
|
||||
emptyMessage="No roles match your search"
|
||||
/>
|
||||
</>
|
||||
}
|
||||
detail={selected ? (
|
||||
<>
|
||||
<div className={styles.detailHeader}>
|
||||
<Avatar name={selected.name} size="lg" />
|
||||
<div className={styles.detailHeaderInfo}>
|
||||
<div className={styles.detailName}>{selected.name}</div>
|
||||
{selected.description && (
|
||||
<div className={styles.detailEmail}>{selected.description}</div>
|
||||
)}
|
||||
</div>
|
||||
{!selected.system && (
|
||||
<Button
|
||||
size="sm"
|
||||
variant="danger"
|
||||
onClick={() => setDeleteTarget(selected)}
|
||||
>
|
||||
Delete
|
||||
</Button>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<div className={styles.metaGrid}>
|
||||
<span className={styles.metaLabel}>ID</span>
|
||||
<MonoText size="xs">{selected.id}</MonoText>
|
||||
<span className={styles.metaLabel}>Scope</span>
|
||||
<span className={styles.metaValue}>{selected.scope}</span>
|
||||
{selected.system && (
|
||||
<>
|
||||
<span className={styles.metaLabel}>Type</span>
|
||||
<span className={styles.metaValue}>System role (read-only)</span>
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Assigned to groups</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{assignedGroups.map((g) => <Tag key={g.id} label={g.name} color="success" />)}
|
||||
{assignedGroups.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Assigned to users (direct)</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{directUsers.map((u) => <Tag key={u.id} label={u.displayName} color="auto" />)}
|
||||
{directUsers.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
|
||||
<SectionHeader>Effective principals</SectionHeader>
|
||||
<div className={styles.sectionTags}>
|
||||
{effectivePrincipals.map((u) => {
|
||||
const isDirect = u.directRoles.includes(selected.name)
|
||||
return (
|
||||
<Badge
|
||||
key={u.id}
|
||||
label={u.displayName}
|
||||
color="auto"
|
||||
variant={isDirect ? 'filled' : 'dashed'}
|
||||
/>
|
||||
)
|
||||
})}
|
||||
{effectivePrincipals.length === 0 && <span className={styles.inheritedNote}>(none)</span>}
|
||||
</div>
|
||||
{effectivePrincipals.some((u) => !u.directRoles.includes(selected.name)) && (
|
||||
<span className={styles.inheritedNote}>
|
||||
Dashed entries inherit this role through group membership
|
||||
</span>
|
||||
)}
|
||||
</>
|
||||
) : null}
|
||||
emptyMessage="Select a role to view details"
|
||||
/>
|
||||
|
||||
<ConfirmDialog
|
||||
open={deleteTarget !== null}
|
||||
|
||||
Reference in New Issue
Block a user