claude/kochwas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(shopping): NULLIF-Guard gegen servings_default=0 in Aggregation
Some checks failed
Build & Publish Docker Image / build-and-push (push) Has been cancelled
Details

Browse Source
This commit is contained in:
hsiegeln
2026-04-21 23:06:19 +02:00
parent c31a9c6110
commit 494b672e8d
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/server/shopping/repository.ts
View File

@@ -87,7 +87,7 @@ export function listShoppingList(
LOWER(TRIM(COALESCE(i.unit, ''))) AS unit_key, LOWER(TRIM(COALESCE(i.unit, ''))) AS unit_key,
MIN(i.name) AS display_name, MIN(i.name) AS display_name,
MIN(i.unit) AS display_unit, MIN(i.unit) AS display_unit,
SUM(i.quantity * cr.servings * 1.0 / COALESCE(r.servings_default, cr.servings)) AS total_quantity, SUM(i.quantity * cr.servings * 1.0 / NULLIF(COALESCE(r.servings_default, cr.servings), 0)) AS total_quantity,
GROUP_CONCAT(DISTINCT r.title) AS from_recipes, GROUP_CONCAT(DISTINCT r.title) AS from_recipes,
EXISTS( EXISTS(
SELECT 1 FROM shopping_cart_check c SELECT 1 FROM shopping_cart_check c

12
tests/integration/shopping-repository.test.ts
View File

@@ -172,4 +172,16 @@ describe('listShoppingList aggregation', () => {
addRecipeToCart(db, id, null); addRecipeToCart(db, id, null);
expect(listShoppingList(db).uncheckedCount).toBe(2); expect(listShoppingList(db).uncheckedCount).toBe(2);
}); });
it('does not blow up when servings_default is zero (silent NULL total_quantity)', () => {
const db = openInMemoryForTest();
const id = insertRecipe(db, recipe({
servings_default: 0,
ingredients: [{ position: 1, quantity: 100, unit: 'g', name: 'Mehl', note: null, raw_text: '', section_heading: null }]
}));
addRecipeToCart(db, id, null, 4);
const rows = listShoppingList(db).rows;
expect(rows).toHaveLength(1);
expect(rows[0].total_quantity).toBeNull();
});
}); });