feat(ui): custom dialog replaces all remaining window.alert() calls
All checks were successful
Build & Publish Docker Image / build-and-push (push) Successful in 53s

alertAction({title, message}) returns Promise<void> and renders the
same ConfirmDialog with infoOnly:true — single OK button, no Abbrechen.
Replaces:
- 'Bitte Profil wählen.' (recipe rating / favorite / cooked / comment)
- 'Bitte Profil wählen, um zu liken.' (wishlist)
- 'Profil konnte nicht angelegt werden' (ProfileSwitcher)
- 'Umbenennen fehlgeschlagen' (admin/profiles)
- 'Speichern fehlgeschlagen' (preview)

No window.alert() or window.confirm() left in the codebase.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-17 17:23:07 +02:00
parent 1b9928f806
commit 4f7c76c908
7 changed files with 59 additions and 18 deletions

View File

@@ -1,6 +1,6 @@
<script lang="ts">
import { profileStore } from '$lib/client/profile.svelte';
import { confirmAction } from '$lib/client/confirm.svelte';
import { confirmAction, alertAction } from '$lib/client/confirm.svelte';
let newName = $state('');
let newEmoji = $state('🍳');
@@ -31,7 +31,10 @@
});
if (!res.ok) {
const body = await res.json().catch(() => ({}));
alert(`Fehler: ${body.message ?? res.status}`);
await alertAction({
title: 'Umbenennen fehlgeschlagen',
message: body.message ?? `HTTP ${res.status}`
});
return;
}
await profileStore.load();

View File

@@ -2,6 +2,7 @@
import { page } from '$app/stores';
import { goto } from '$app/navigation';
import RecipeView from '$lib/components/RecipeView.svelte';
import { alertAction } from '$lib/client/confirm.svelte';
import type { Recipe } from '$lib/types';
let targetUrl = $state(($page.url.searchParams.get('url') ?? '').trim());
@@ -45,7 +46,10 @@
saving = false;
if (!res.ok) {
const body = await res.json().catch(() => ({}));
alert(`Speichern fehlgeschlagen: ${body.message ?? res.status}`);
await alertAction({
title: 'Speichern fehlgeschlagen',
message: body.message ?? `HTTP ${res.status}`
});
return;
}
const body = await res.json();

View File

@@ -4,7 +4,7 @@
import RecipeView from '$lib/components/RecipeView.svelte';
import StarRating from '$lib/components/StarRating.svelte';
import { profileStore } from '$lib/client/profile.svelte';
import { confirmAction } from '$lib/client/confirm.svelte';
import { confirmAction, alertAction } from '$lib/client/confirm.svelte';
import type { CommentRow } from '$lib/server/recipes/actions';
let { data } = $props();
@@ -40,7 +40,10 @@
async function setRating(stars: number) {
if (!profileStore.active) {
alert('Bitte erst Profil wählen.');
await alertAction({
title: 'Kein Profil gewählt',
message: 'Tippe oben rechts auf „Profil wählen", dann klappt die Aktion.'
});
return;
}
await fetch(`/api/recipes/${data.recipe.id}/rating`, {
@@ -55,7 +58,10 @@
async function toggleFavorite() {
if (!profileStore.active) {
alert('Bitte erst Profil wählen.');
await alertAction({
title: 'Kein Profil gewählt',
message: 'Tippe oben rechts auf „Profil wählen", dann klappt die Aktion.'
});
return;
}
const method = isFav ? 'DELETE' : 'PUT';
@@ -69,7 +75,10 @@
async function logCooked() {
if (!profileStore.active) {
alert('Bitte erst Profil wählen.');
await alertAction({
title: 'Kein Profil gewählt',
message: 'Tippe oben rechts auf „Profil wählen", dann klappt die Aktion.'
});
return;
}
const res = await fetch(`/api/recipes/${data.recipe.id}/cooked`, {
@@ -83,7 +92,10 @@
async function addComment() {
if (!profileStore.active) {
alert('Bitte erst Profil wählen.');
await alertAction({
title: 'Kein Profil gewählt',
message: 'Tippe oben rechts auf „Profil wählen", dann klappt die Aktion.'
});
return;
}
const text = newComment.trim();

View File

@@ -1,7 +1,7 @@
<script lang="ts">
import { onMount } from 'svelte';
import { profileStore } from '$lib/client/profile.svelte';
import { confirmAction } from '$lib/client/confirm.svelte';
import { confirmAction, alertAction } from '$lib/client/confirm.svelte';
import type { WishlistEntry, SortKey } from '$lib/server/wishlist/repository';
let entries = $state<WishlistEntry[]>([]);
@@ -27,7 +27,10 @@
async function toggleLike(entry: WishlistEntry) {
if (!profileStore.active) {
alert('Bitte Profil wählen, um zu liken.');
await alertAction({
title: 'Kein Profil gewählt',
message: 'Tippe oben rechts auf „Profil wählen", um zu liken.'
});
return;
}
const method = entry.liked_by_me ? 'DELETE' : 'PUT';