cameleer/cameleer-server
1
0
Fork 0
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(deploy): widen promote FAILURE audit detail + clean up test envs

Browse Source
This commit is contained in:
hsiegeln
2026-04-23 12:29:46 +02:00
parent 47d5611462
commit 2312a7304d
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cameleer-server-app/src/main/java/com/cameleer/server/app/controller/DeploymentController.java
View File

@@ -172,7 +172,8 @@ public class DeploymentController {
return ResponseEntity.accepted().body(promoted); return ResponseEntity.accepted().body(promoted);
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
auditService.log("promote_deployment", AuditCategory.DEPLOYMENT, deploymentId.toString(), auditService.log("promote_deployment", AuditCategory.DEPLOYMENT, deploymentId.toString(),
Map.of("appSlug", appSlug, "error", e.getMessage()), Map.of("sourceEnv", env.slug(), "targetEnv", request.targetEnvironment(),
"appSlug", appSlug, "error", e.getMessage()),
AuditResult.FAILURE, httpRequest); AuditResult.FAILURE, httpRequest);
return ResponseEntity.status(HttpStatus.NOT_FOUND) return ResponseEntity.status(HttpStatus.NOT_FOUND)
.body(Map.of("error", e.getMessage())); .body(Map.of("error", e.getMessage()));

3
cameleer-server-app/src/test/java/com/cameleer/server/app/controller/DeploymentControllerAuditIT.java
View File

@@ -46,10 +46,11 @@ class DeploymentControllerAuditIT extends AbstractPostgresIT {
aliceJwt = securityHelper.createToken("user:alice", "user", List.of("OPERATOR")); aliceJwt = securityHelper.createToken("user:alice", "user", List.of("OPERATOR"));
adminJwt = securityHelper.adminToken(); adminJwt = securityHelper.adminToken();
// Clean up deployment-related tables // Clean up deployment-related tables and test-created environments
jdbcTemplate.update("DELETE FROM deployments"); jdbcTemplate.update("DELETE FROM deployments");
jdbcTemplate.update("DELETE FROM app_versions"); jdbcTemplate.update("DELETE FROM app_versions");
jdbcTemplate.update("DELETE FROM apps"); jdbcTemplate.update("DELETE FROM apps");
jdbcTemplate.update("DELETE FROM environments WHERE slug LIKE 'promote-target-%'");
jdbcTemplate.update("DELETE FROM audit_log"); jdbcTemplate.update("DELETE FROM audit_log");
// Ensure alice exists in the users table (required for deployments.created_by FK) // Ensure alice exists in the users table (required for deployments.created_by FK)