Surfaced during second smoke:
1. Notification bell moved — was first child of TopBar (left of
breadcrumb); now rendered inside the `environment` slot so it
sits between the env selector and the user menu, matching user
expectations.
2. Content tabs (Exchanges/Dashboard/Runtime/Deployments) hidden on
`/alerts/*` — the operational tabs don't apply there.
3. Inbox / All alerts filters now actually filter. `AlertController.list`
accepts only `limit` — `state`/`severity` query params are dropped
server-side. Move `useAlerts` to fetch once per env (limit 200) and
apply filters client-side via react-query `select`, with a stable
queryKey so filter toggles are instant and don't re-request. True
server-side filter needs a backend change (follow-up).
4. Novice-friendly labels:
- Inbox subtitle: "99 firing · 100 total" → "99 need attention ·
100 total in inbox"
- All alerts filter: Open/Firing/Acked/All →
"Currently open"/"Firing now"/"Acknowledged"/"All states"
- All alerts subtitle: "N shown" → "N matching your filter"
- History subtitle: "N resolved" → "N resolved alert(s) in range"
- Rules subtitle: "N total" → "N rule(s) configured"
- Silences subtitle: "N active" → "N active silence(s)" or
"Nothing silenced right now"
- Column headers: "State" → "Status", rules "Kind" → "Type",
rules "Targets" → "Notifies"
- Buttons: "Ack" → "Acknowledge", silence "End" → "End early"
Updated alerts.test.tsx and e2e selector to match new behavior/labels.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
126 lines
4.4 KiB
TypeScript
126 lines
4.4 KiB
TypeScript
import { useState } from 'react';
|
|
import { Link } from 'react-router';
|
|
import { History } from 'lucide-react';
|
|
import {
|
|
DataTable, EmptyState, DateRangePicker,
|
|
} from '@cameleer/design-system';
|
|
import type { Column } from '@cameleer/design-system';
|
|
import { PageLoader } from '../../components/PageLoader';
|
|
import { SeverityBadge } from '../../components/SeverityBadge';
|
|
import {
|
|
useAlerts, type AlertDto,
|
|
} from '../../api/queries/alerts';
|
|
import { severityToAccent } from './severity-utils';
|
|
import { formatRelativeTime } from './time-utils';
|
|
import { renderAlertExpanded } from './alert-expanded';
|
|
import css from './alerts-page.module.css';
|
|
import tableStyles from '../../styles/table-section.module.css';
|
|
|
|
/** Duration in s/m/h/d. Pure, best-effort. */
|
|
function formatDuration(from?: string | null, to?: string | null): string {
|
|
if (!from || !to) return '—';
|
|
const ms = new Date(to).getTime() - new Date(from).getTime();
|
|
if (ms < 0 || Number.isNaN(ms)) return '—';
|
|
const sec = Math.floor(ms / 1000);
|
|
if (sec < 60) return `${sec}s`;
|
|
if (sec < 3600) return `${Math.floor(sec / 60)}m`;
|
|
if (sec < 86_400) return `${Math.floor(sec / 3600)}h`;
|
|
return `${Math.floor(sec / 86_400)}d`;
|
|
}
|
|
|
|
export default function HistoryPage() {
|
|
const [dateRange, setDateRange] = useState({
|
|
start: new Date(Date.now() - 7 * 24 * 3600_000),
|
|
end: new Date(),
|
|
});
|
|
|
|
// useAlerts doesn't accept a time range today; filter client-side.
|
|
const { data, isLoading, error } = useAlerts({ state: 'RESOLVED', limit: 200 });
|
|
|
|
const filtered = (data ?? []).filter((a) => {
|
|
if (!a.firedAt) return false;
|
|
const t = new Date(a.firedAt).getTime();
|
|
return t >= dateRange.start.getTime() && t <= dateRange.end.getTime();
|
|
});
|
|
|
|
const columns: Column<AlertDto>[] = [
|
|
{
|
|
key: 'severity', header: 'Severity', width: '110px',
|
|
render: (_, row) => row.severity ? <SeverityBadge severity={row.severity} /> : null,
|
|
},
|
|
{
|
|
key: 'title', header: 'Title',
|
|
render: (_, row) => (
|
|
<div className={css.titleCell}>
|
|
<Link to={`/alerts/inbox/${row.id}`}>{row.title ?? '(untitled)'}</Link>
|
|
{row.message && <span className={css.titlePreview}>{row.message}</span>}
|
|
</div>
|
|
),
|
|
},
|
|
{
|
|
key: 'firedAt', header: 'Fired at', width: '140px', sortable: true,
|
|
render: (_, row) =>
|
|
row.firedAt ? (
|
|
<span title={row.firedAt} style={{ fontVariantNumeric: 'tabular-nums' }}>
|
|
{formatRelativeTime(row.firedAt)}
|
|
</span>
|
|
) : '—',
|
|
},
|
|
{
|
|
key: 'resolvedAt', header: 'Resolved at', width: '140px', sortable: true,
|
|
render: (_, row) =>
|
|
row.resolvedAt ? (
|
|
<span title={row.resolvedAt} style={{ fontVariantNumeric: 'tabular-nums' }}>
|
|
{formatRelativeTime(row.resolvedAt)}
|
|
</span>
|
|
) : '—',
|
|
},
|
|
{
|
|
key: 'duration', header: 'Duration', width: '90px',
|
|
render: (_, row) => formatDuration(row.firedAt, row.resolvedAt),
|
|
},
|
|
];
|
|
|
|
if (isLoading) return <PageLoader />;
|
|
if (error) return <div className={css.page}>Failed to load history: {String(error)}</div>;
|
|
|
|
return (
|
|
<div className={css.page}>
|
|
<header className={css.pageHeader}>
|
|
<div className={css.pageTitleGroup}>
|
|
<h2 className={css.pageTitle}>Alert history</h2>
|
|
<span className={css.pageSubtitle}>
|
|
{filtered.length === 0
|
|
? 'No resolved alerts in range'
|
|
: `${filtered.length} resolved alert${filtered.length === 1 ? '' : 's'} in range`}
|
|
</span>
|
|
</div>
|
|
<div className={css.pageActions}>
|
|
<DateRangePicker value={dateRange} onChange={setDateRange} />
|
|
</div>
|
|
</header>
|
|
|
|
{filtered.length === 0 ? (
|
|
<EmptyState
|
|
icon={<History size={32} />}
|
|
title="No resolved alerts"
|
|
description="Nothing in the selected date range. Try widening it."
|
|
/>
|
|
) : (
|
|
<div className={`${tableStyles.tableSection} ${css.tableWrap}`}>
|
|
<DataTable<AlertDto & { id: string }>
|
|
columns={columns as Column<AlertDto & { id: string }>[]}
|
|
data={filtered as Array<AlertDto & { id: string }>}
|
|
sortable
|
|
flush
|
|
fillHeight
|
|
pageSize={200}
|
|
rowAccent={(row) => row.severity ? severityToAccent(row.severity) : undefined}
|
|
expandedContent={renderAlertExpanded}
|
|
/>
|
|
</div>
|
|
)}
|
|
</div>
|
|
);
|
|
}
|